Skip to content

docs: cleanup vuetify layout#355

Open
userquin wants to merge 5 commits into
mainfrom
joaquin/docs-add-hero-animations
Open

docs: cleanup vuetify layout#355
userquin wants to merge 5 commits into
mainfrom
joaquin/docs-add-hero-animations

Conversation

@userquin

@userquin userquin commented Mar 19, 2026

Copy link
Copy Markdown
Member

Description

This PR moves the logic at Vuetify layout to the index.ts module, we don't need to create and mount a vue application for that.

This PR also includes:

  • added animated-logo.svg back but still not being used: I need to check why the SVG only runs the animation once, on page refresh the animation is missing
  • add animated-logo.svg and use it at home hero: looks like it is not working with dev server, you need to run docs:serve (build + vp preview) => there is some weird behavior, sometimes the animations are there sometimes missing (chrome, brave and firefox on Windows) when using the VP navigation or the back briwser button, on page refresh it works...
  • fix theme color contrast for brand button, tip, warning, error and info blocks
  • fix shiki theme color contrast (github-light theme)

Linked Issues

Additional Context

I've sent a PR to VitePress to include a new hero actions slot, this PR updates VP to v2 alpha 17 and uses the new slot home-hero-actions-before-actions to add the npx input box before VP actions list but inside actions container:
vuejs/vitepress#5151


Tip

The author of this PR can publish a preview release by commenting /publish below.

@userquin userquin requested a review from AndreyYolkin March 19, 2026 18:20
Comment thread docs/.vitepress/theme/components/HomeHeroCopy.vue Outdated
@userquin

Copy link
Copy Markdown
Member Author

Don't merge yet, we're adding support for Shiki colorReplacements at VitePress:
vuejs/vitepress#5153

@AndreyYolkin AndreyYolkin added documentation Improvements or additions to documentation needs rebase Has merge conflicts; needs rebase on base branch labels Jun 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation needs rebase Has merge conflicts; needs rebase on base branch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants